Skip to content

Update vs-solutionpersistence to 1.0.9#392

Merged
MichaelSimons merged 1 commit intodotnet:mainfrom
kasperk81:main
Oct 15, 2024
Merged

Update vs-solutionpersistence to 1.0.9#392
MichaelSimons merged 1 commit intodotnet:mainfrom
kasperk81:main

Conversation

@kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Oct 15, 2024 

 .packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24509.3/tools/SourceBuild/AfterSourceBuild.proj#L81

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24509.3/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.VisualStudio.SolutionPersistence.1.0.9

error from dotnet/msbuild#10794

@kasperk81 kasperk81 mentioned this pull request Oct 15, 2024
Merged
@kasperk81
Copy link
Contributor Author

kasperk81 commented Oct 15, 2024

@MichaelSimons 1.0.9 is their first version which made to nuget https://www.nuget.org/packages/Microsoft.VisualStudio.SolutionPersistence#versions-body-tab, so this bump in needed to unblock msbuild.

@MichaelSimons
Copy link
Member

MichaelSimons commented Oct 15, 2024

@richardstanton - given this is the first upgrade, I would appreciate your sign-off as well.

@kasperk81
Copy link
Contributor Author

kasperk81 commented Oct 15, 2024

Note there is no risk. msbuild is the first dotnet org consuming vs-solutionpersistence library and nothing is consuming 1.0.6 simply because it doesn't exist as a package.

@MichaelSimons MichaelSimons merged commit cecf0ad into dotnet:main Oct 15, 2024
@mthalman mthalman mentioned this pull request Oct 17, 2024
Merged
@kasperk81 kasperk81 mentioned this pull request Nov 14, 2024
Merged
@kasperk81 kasperk81 mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@mthalman mthalman Awaiting requested review from mthalman

+1 more reviewer

@richardstanton richardstanton richardstanton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kasperk81 @MichaelSimons @richardstanton