Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 17, 2024

No description provided.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the rate of version updates? Have you considered attempting to upstream a version of these changes that would add build config knobs to support .NET SB?

@wtgodbe
Copy link
Member Author

wtgodbe commented Jul 17, 2024

Given the rate of version updates? Have you considered attempting to upstream a version of these changes that would add build config knobs to support .NET SB?

As in, add some props to the IdentityModel repo so that we could conditionalize the stuff that we currently change in the .patch file? I haven't, but that's a good idea. I can run it by the folks from IdentityModel

@MichaelSimons MichaelSimons merged commit ff7fd0e into dotnet:main Jul 17, 2024
@MichaelSimons
Copy link
Member

As in, add some props to the IdentityModel repo so that we could conditionalize the stuff that we currently change in the .patch file? I haven't, but that's a good idea. I can run it by the folks from IdentityModel

Yes that is exactly what I was thinking - e.g. ExcludeFxCop, ExcludeFullFxTfms, etc.

@wtgodbe wtgodbe deleted the IdentityModel800 branch July 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants