Remove explicit handling of git commits#312
Merged
MichaelSimons merged 1 commit intodotnet:mainfrom May 8, 2024
Merged
Conversation
Rely on submodules/projects to find and use the correct git commit automagically. This is already handled by sourcelink, which uses full git metadata if avaialable or minimal git metadata otherwise. In fact, it doesn't look like any of the submodules/projects here use git commit info at all, other than humanizer. src/humanizer/NuSpecs/Humanizer.Core.nuspec includes a `<repository>` element with a `$RepositoryCommit$` variablea but the nupsec inside the built humanizer nupkg doesn't include this element either before or after this change. [1] https://github.com/dotnet/sourcelink/tree/main/docs#minimal-git-repository-metadata
MichaelSimons
approved these changes
Apr 22, 2024
Member
Author
|
If this PR is okay, can someone please merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rely on submodules/projects to find and use the correct git commit automagically. This is already handled by sourcelink, which uses full git metadata if avaialable or minimal git metadata otherwise.
In fact, it doesn't look like any of the submodules/projects here use git commit info at all, other than humanizer.
src/humanizer/NuSpecs/Humanizer.Core.nuspec includes a
<repository>element with a$RepositoryCommit$variablea but the nupsec inside the built humanizer nupkg doesn't include this element either before or after this change.[1] https://github.com/dotnet/sourcelink/tree/main/docs#minimal-git-repository-metadata