Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/source-build-externals
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 94b5dd594f
Choose a base ref
...
head repository: dotnet/source-build-externals
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7dc4b475c0
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 8, 2024

  1. Remove explicit handling of git commits (#312) 

    Rely on submodules/projects to find and use the correct git commit
automagically. This is already handled by sourcelink, which uses full
git metadata if avaialable or minimal git metadata otherwise.

In fact, it doesn't look like any of the submodules/projects here use
git commit info at all, other than humanizer.

src/humanizer/NuSpecs/Humanizer.Core.nuspec includes a `<repository>`
element with a `$RepositoryCommit$` variablea but the nupsec inside the
built humanizer nupkg doesn't include this element either before or
after this change.

[1] https://github.com/dotnet/sourcelink/tree/main/docs#minimal-git-repository-metadata
    @omajid
    omajid authored May 8, 2024
    Configuration menu
    Copy the full SHA
    7dc4b47 View commit details
    Browse the repository at this point in the history
Loading