Skip to content

Conversation

@tmds
Copy link
Member

tmds commented Nov 29, 2019

imo, we don't want much granularity in source-build.
From maintainer perspective having separate packages adds additional complexity.
There should be a gain/rationale for that complexity.

The repositories that are used by source-build have proper release branches. We should be able to rely on that to have confidence re-built binaries only have minimal changes.

@dagood
Copy link
Member Author

dagood commented Dec 2, 2019

The repositories that are used by source-build have proper release branches.

From a Linux distro packaging perspective, they don't, IMO. The way the Microsoft build works, the shape of a repo's outputs on the release branch changes over time. What you get depends on what's being patched for the upcoming servicing version Microsoft plans to release. Forcing packages to build in the release branch puts us into territory that is unexplored by the Microsoft build and its tests.

We don't have to make extreme decisions based on this, but it's the root of the difference here.

@dagood
Copy link
Member Author

dagood commented Feb 4, 2020

I reworked it to focus on the recommended approach and moved the bulk of the doc (explaining why granularity is bad for source-build) into a different file. It should be much more readable now.

@dagood dagood force-pushed the servicing-granularity branch from e105441 to 88d37d5 Compare April 13, 2020 17:52
@dagood
Copy link
Member Author

dagood commented Apr 13, 2020

I moved the doc to fit in better with Documentation/planning/arcade-powered-source-build/README.md and added a small reference. This is something we should consider for 5.0--it would be bad to hit one of these pitfalls as we're getting the source-built SDK into more distros. I believe this should be incremental work after getting the initial source-build-in-arcade plan done. Once we merge the doc we can write up issues that reference it as appropriate.

@dseefeld PTAL

@dagood dagood merged commit 253165d into dotnet:release/3.1 Apr 22, 2020
@dagood dagood deleted the servicing-granularity branch April 22, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants