Remove source-built dir from tarball in favor of prev source-built archive #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chive - Remove copying of assets to source-built dir in tarball - On initial tarball build, lookup boostrap versions of arcade, sourcelink and DotNetHost from previously source-built archive and use those versions when building arcade, sourcelink and corefx.
crummel
approved these changes
Nov 15, 2019
- Keep a list of packages that are detected as prebuilts even though they aren't used in the tarball build. - Delete these packages after doing the normal filtering. - Enforce zero prebuilts in build-source-tarball, with a whitelist in case we need to regress on prebuilts. * Add an option to skip zero prebuilt enforcement. * Don't fail on missing prebuilts
…chive - Remove copying of assets to source-built dir in tarball - On initial tarball build, lookup boostrap versions of arcade, sourcelink and DotNetHost from previously source-built archive and use those versions when building arcade, sourcelink and corefx.
…e-build into removeSourceBuilt Conflicts: dir.props
adaggarwal
approved these changes
Nov 18, 2019
crummel
approved these changes
Nov 19, 2019
* Include coreclr-tools in source-built archive * Add add'l pkgs to delete when generating tarball * Sort additional prebuilts to delete text file * Report all disallowed prebuilts on tarball creation
…chive - Remove copying of assets to source-built dir in tarball - On initial tarball build, lookup boostrap versions of arcade, sourcelink and DotNetHost from previously source-built archive and use those versions when building arcade, sourcelink and corefx.
Contributor
Author
|
This work is in 3.1 with #1397. Closing this for 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and DotNetHost from previously source-built archive and use those
versions when building arcade, sourcelink and corefx.
Fixes #1358