Skip to content

NoTargets & Traversal Source Built Sdk Overrides use the input version instead of the package output version #4297

@ViktorHofer

Description

@ViktorHofer

See https://github.com/dotnet/installer/blob/1bdd67177fffd789918216c084d855372dcf607e/src/SourceBuild/content/repo-projects/Directory.Build.props#L217-L218

These two lines should use the package output version produced by SBRP not the input version that is read from the global.json file in build.sh.

Note that dotnet/installer#19317 will remove the arcadeOutputPackageVersion. Therefore we shouldn't not depend on outputpackageversion from the AllRepoVersions.props (which wouldn't work anyways as those two msbuild sdks use a different version than the repo version).

Instead, those versions should be retrieved from the SBRP build manifest when building from source and only if the repo isn't SBRP.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-buildImprovements in source-build's own build processuntriaged

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions