Skip to content

Add BundledNETCoreAppTargetFramework to BundledVersions.props#52310

Merged
ViktorHofer merged 1 commit intomainfrom
ViktorHofer-patch-1
Jan 5, 2026
Merged

Add BundledNETCoreAppTargetFramework to BundledVersions.props#52310
ViktorHofer merged 1 commit intomainfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer
Copy link
Member

Related to #29949 but initially just adding a property so that we can easier target the TFM that the SDK provides offline packs for.

Related to #29949 but initially just adding a property so that we can easier target the TFM that the SDK provides offline packs for.
Copilot AI review requested due to automatic review settings January 5, 2026 14:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new MSBuild property BundledNETCoreAppTargetFramework to the generated BundledVersions.props file, making it easier for consumers to target the exact Target Framework Moniker (TFM) that the SDK provides offline packs for. The property combines "net" with the existing version number to create a complete TFM string like "net11.0".

  • Adds BundledNETCoreAppTargetFramework property constructed as net$(_NETCoreAppTargetFrameworkVersion)

@baronfel
Copy link
Member

baronfel commented Jan 5, 2026

As follow-on work we should change the implementation of the test framework/etc to use this value instead of hardcoding it, if possible.

@baronfel
Copy link
Member

baronfel commented Jan 5, 2026

Added the 'Document for new feature' label so that we track doc'ing the new property in the main SDK docs on dotnet/docs.

@baronfel baronfel added this to the 11.0.1xx milestone Jan 5, 2026
@ViktorHofer ViktorHofer merged commit 90754c5 into main Jan 5, 2026
32 of 35 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch January 5, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants