Skip to content

Comments

In-proc workspace#52163

Closed
tmat wants to merge 1 commit intodotnet:release/10.0.2xxfrom
tmat:InprocWorkspace
Closed

In-proc workspace#52163
tmat wants to merge 1 commit intodotnet:release/10.0.2xxfrom
tmat:InprocWorkspace

Conversation

@tmat
Copy link
Member

@tmat tmat commented Dec 15, 2025

No description provided.

@tmat tmat changed the base branch from main to release/10.0.2xx December 15, 2025 17:12
@tmat tmat changed the title Inproc workspace In-proc workspace Dec 15, 2025
tmat added a commit to dotnet/roslyn that referenced this pull request Jan 6, 2026
Refactors BuildHost and MSBuildProjectLoader to allow dotnet-watch to
populate workspace in-proc based on already evaluated ProjectInstances
(loaded via ProjectGraph).

- Factors language specific retrieval of command line arguments out of
`ProjectFile` into separate types: `XyzProjectCommandLineProvider`.
- Factors construction of `ProjectFileInfo` based on `ProjectInstance`
into a separate type: `ProjectInstanceReader`. The reader takes project
instance and optionally MSBuild `Project` and extracts the necessary
info from its properties and items. The `Project` is optional - it is
only needed to populate `FileGlobs`.
- Adds `HotReloadMSBuildWorkspace` - this is a replacement for
dotnet-watch's
[IncrementalMSBuildWorkspace](https://github.com/dotnet/sdk/blob/main/src/BuiltInTools/Watch/HotReload/IncrementalMSBuildWorkspace.cs)
- Adds interface `IProjectFileInfoProvider` that abstract away retrieval
of `ProjectFileInfo`s. `MSBuildWorkspace` uses an implementation that
dispatches to OOP while `HotReloadMSBuildWorkspace` uses impl that
calculates the information directly (in-proc) from project instances
provided by dotnet-watch.
- Updates BuildHost project to build first-class NuGet package.

dotnet-watch usage: dotnet/sdk#52163
@mmitche mmitche deleted the branch dotnet:release/10.0.2xx January 17, 2026 00:38
@mmitche mmitche closed this Jan 17, 2026
@marcpopMSFT marcpopMSFT reopened this Jan 20, 2026
@tmat
Copy link
Member Author

tmat commented Feb 10, 2026

Part of #52648

@tmat tmat closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants