Closed
Conversation
tmat
added a commit
to dotnet/roslyn
that referenced
this pull request
Jan 6, 2026
Refactors BuildHost and MSBuildProjectLoader to allow dotnet-watch to populate workspace in-proc based on already evaluated ProjectInstances (loaded via ProjectGraph). - Factors language specific retrieval of command line arguments out of `ProjectFile` into separate types: `XyzProjectCommandLineProvider`. - Factors construction of `ProjectFileInfo` based on `ProjectInstance` into a separate type: `ProjectInstanceReader`. The reader takes project instance and optionally MSBuild `Project` and extracts the necessary info from its properties and items. The `Project` is optional - it is only needed to populate `FileGlobs`. - Adds `HotReloadMSBuildWorkspace` - this is a replacement for dotnet-watch's [IncrementalMSBuildWorkspace](https://github.com/dotnet/sdk/blob/main/src/BuiltInTools/Watch/HotReload/IncrementalMSBuildWorkspace.cs) - Adds interface `IProjectFileInfoProvider` that abstract away retrieval of `ProjectFileInfo`s. `MSBuildWorkspace` uses an implementation that dispatches to OOP while `HotReloadMSBuildWorkspace` uses impl that calculates the information directly (in-proc) from project instances provided by dotnet-watch. - Updates BuildHost project to build first-class NuGet package. dotnet-watch usage: dotnet/sdk#52163
Member
Author
|
Part of #52648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.