-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add deprecation warning NETSDK1234 for RoslynCompilerType=Framework #51723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjonescz
merged 5 commits into
release/10.0.2xx
from
copilot/add-deprecation-warning-roslyncompiler
Nov 19, 2025
Merged
Add deprecation warning NETSDK1234 for RoslynCompilerType=Framework #51723
jjonescz
merged 5 commits into
release/10.0.2xx
from
copilot/add-deprecation-warning-roslyncompiler
Nov 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jjonescz <[email protected]>
Copilot
AI
changed the title
[WIP] Add deprecation warning for RoslynCompilerType=Framework
Add deprecation warning NETSDK1234 for RoslynCompilerType=Framework
Nov 13, 2025
jjonescz
reviewed
Nov 14, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RoslynCompilerTypeDeprecation.targets
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jjonescz <[email protected]>
jjonescz
reviewed
Nov 14, 2025
test/Microsoft.NET.Build.Tests/GivenThatWeWantToDetectDeprecatedRoslynCompilerType.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jjonescz <[email protected]>
jjonescz
approved these changes
Nov 14, 2025
333fred
reviewed
Nov 18, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.targets
Outdated
Show resolved
Hide resolved
Co-authored-by: jjonescz <[email protected]>
333fred
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/roslyn#81184.
Plan for Adding Deprecation Warning for RoslynCompilerType=Framework
Changes Made
PR Feedback Addressed
Microsoft.NET.Sdk.BeforeCommon.targets(removed separate file)sealedkeyword to test classRoslynCompilerType,Framework, and{0}/nowarn:NETSDK1234in command line output on WindowsImplementation
Strings.resx): NETSDK1234 with proper locked attributesMicrosoft.NET.Sdk.BeforeCommon.targets): Checks for deprecated value and emits warningAll tests passing: 6/6 ✅
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.