Skip to content

Condition NuGet pack in Microsoft.Net.Sdk on framework only #50902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zivkan merged 1 commit into from
Sep 19, 2025
Merged

Condition NuGet pack in Microsoft.Net.Sdk on framework only #50902

zivkan merged 1 commit into from
Sep 19, 2025

Conversation

@zivkan
Copy link
Member

@zivkan zivkan commented Sep 18, 2025 •
edited
Loading

fixes: #50767

In order for nuget to support non-SDK style project pack in Visual Studio, I changed the layout for a bunch of files related to pack. This made it into the SDK via the VMR insertion: dotnet/dotnet#2126

@zivkan
Copy link
Member Author

zivkan commented Sep 18, 2025

When I build locally, I still get NuGet.ProjectModel.dll and all of its dependencies in Sdks\Microsoft.Net.Sdk\tools\net10.0. I don't understand why these files were NOT being copied before my pack changes, as this csproj had a reference to NuGet.ProjectModel for 8 years. I haven't had time to look into binlogs to try to understand why it wasn't being copied before. Removing the package reference causes a compile error.

fyi @marcpopMSFT @DrewScoggins

@zivkan
Copy link
Member Author

zivkan commented Sep 19, 2025

Looks like I forgot to clean the artifacts directory. Doing so and rebuilding locally, I no longer see any of the extra dlls in the tools/net10.0 directory. Ready for review and merge.

@baronfel baronfel requested a review from a team September 19, 2025 17:44
dsplaisted
dsplaisted approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It almost seems too simple :-)

It would be nice to eventually have some way of making sure things like this don't accidentally happen again. but this looks good for now.

@zivkan zivkan merged commit ceebdc4 into dotnet:release/10.0.1xx Sep 19, 2025
27 checks passed
@zivkan zivkan mentioned this pull request Sep 19, 2025
Closed
@akoeplinger akoeplinger mentioned this pull request Oct 15, 2025
Open
3 tasks
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@baronfel baronfel baronfel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zivkan @dsplaisted @baronfel