fix(#45761): Stop forwarding dotnet-watch run arguments to all commands#50558
Closed
ronald-mz wants to merge 5 commits intodotnet:release/10.0.1xxfrom
Closed
fix(#45761): Stop forwarding dotnet-watch run arguments to all commands#50558ronald-mz wants to merge 5 commits intodotnet:release/10.0.1xxfrom
ronald-mz wants to merge 5 commits intodotnet:release/10.0.1xxfrom
Conversation
ronald-mz
changed the title
Contributor
Author
|
@dotnet-policy-service agree |
ronald-mz
changed the title
ronald-mz
commented
Aug 30, 2025
| var optionResult = (OptionResult)child; | ||
|
|
||
| // skip watch options: | ||
| if (!watchOptions.Contains(optionResult.Option)) |
Contributor
Author
There was a problem hiding this comment.
Inverting the logic allows a continue to short-circuit the loop.
ronald-mz
commented
Aug 30, 2025
tmat
reviewed
Sep 2, 2025
tmat
reviewed
Sep 2, 2025
Youssef1313
reviewed
Sep 12, 2025
Member
|
@ronald-mz Would you mind rebasing to release/10.0.2xx branch? |
Member
|
I'm going to complete this to get the fix to 10.0.2xx |
Member
|
Superseded by #52387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45761, #45634, and maybe a regression of #34949.
Context
Watch CLI
Problem
dotnet-watchhas-p,--project,--launch-profile, and--no-launch-profileas possible arguments. A user can not use these arguments withoutdotnet-watchforwarding them. These arguments only work with theruncommand, and will cause an error if passed to any command butrun.