Fix source build#49637
Closed
tmat wants to merge 1 commit intodotnet:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables building from source by specifying a compatible targeting pack version when DotNetBuildSourceOnly is true, and broadens test applicability by removing platform-specific constraints.
- Added
<TargetingPackVersion>conditionals in two.csprojfiles to pin .NETCore.App.Ref for source builds. - Updated tests to use
[Fact]instead of[PlatformSpecificFact], removing Windows-only restrictions and related exit-code comments.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Replaced Windows-only [PlatformSpecificFact] with [Fact] and removed exit-code comments. |
| test/dotnet-watch.Tests/CommandLine/ProgramTests.cs | Changed [PlatformSpecificFact] to [Fact] for cross-platform test. |
| src/BuiltInTools/HotReloadAgent/Microsoft.DotNet.HotReload.Agent.Package.csproj | Added conditional <TargetingPackVersion> for source builds. |
| src/BuiltInTools/DotNetDeltaApplier/Microsoft.Extensions.DotNetDeltaApplier.csproj | Added conditional <TargetingPackVersion> for .NET 6.0 source builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.