Set a default for the Http3Support feature switch #49583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref #49564
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets a default for the Http3Support feature switch in the Mono Toolchain manifest, ensuring that the published default matches the previous build-time setting.
- Added a default property for Http3Support with a value of false when not provided.
- Aligns the feature behavior with previous runtime settings mentioned in dotnet/runtime and dotnet/sdk PRs.
Comments suppressed due to low confidence (1)
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WasmFeatures.props:10
- [nitpick] Consider adding a brief comment above this line to document the rationale behind setting the default for Http3Support, referencing its migration from build-time to publish-time control.
<Http3Support Condition="'$(Http3Support)' == ''">false</Http3Support>
This was referenced Jun 27, 2025
akoeplinger
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.
Ref dotnet/runtime#117012
Ref #49564