Set a default for the Http3Support feature switch #49581
Conversation
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref dotnet/runtime#117012 Ref #49564
github-actions
bot
added
the
Area-AspNetCore
|
Thanks for your PR, @@MichalStrehovsky. |
There was a problem hiding this comment.
Pull Request Overview
Sets the default value of the Http3Support feature switch to false in the Blazor WebAssembly 6.0 SDK targets so that publish-time behavior matches the previous build-time default.
- Adds a new
<Http3Support>property with a fallback offalse.
| <UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">true</UseSystemResourceKeys> | ||
| <UseSizeOptimizedLinq Condition="'$(UseSizeOptimizedLinq)' == ''">true</UseSizeOptimizedLinq> | ||
| <EnableUnsafeUTF7Encoding Condition="'$(EnableUnsafeUTF7Encoding)' == ''">false</EnableUnsafeUTF7Encoding> | ||
| <Http3Support Condition="'$(Http3Support)' == ''">false</Http3Support> |
There was a problem hiding this comment.
This change introduces a new default for Http3Support. Consider adding or updating an automated test in the SDK targets tests to verify that when Http3Support is unset it indeed defaults to false.
There was a problem hiding this comment.
Should this be on the wasm SDK directly? /cc @maraf
Ideally, we want this for all webassembly apps, not just Blazor ones
There was a problem hiding this comment.
We don't have same underlying SocketsHttpHandler in wasm. We use browser's fetch. So this should have no impact.
There was a problem hiding this comment.
Should this be on the wasm SDK directly? /cc @maraf
I'm putting this on the other WASM related file here: #49583 (I had that PR out as dotnet/runtime#117081 originally, that's why it's a separate PR).
These both duplicate a lot of these properties and I don't know what's the difference so I'm just piling on where related things are already set.
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.
Ref dotnet/runtime#117012
Ref #49564