Revert "Explicitly enable BF for WinForms and WPF in Microsoft.NET.Sdk.targets" #49562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icrosoft.NET.Sdk.targets"
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous workaround that explicitly enabled EnableUnsafeBinaryFormatterSerialization for WinForms and WPF projects once the underlying runtime issue was fixed in .NET 8.0.
- Removed the override that defaulted
EnableUnsafeBinaryFormatterSerializationtotruefor projects requiring BinaryFormatter. - Relies on .NET 8.0 runtime’s built-in handling instead of the workaround.
Comments suppressed due to low confidence (1)
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets:196
- This revert removes the explicit enabling of BinaryFormatter for project types requiring it, but there are no tests verifying the default behavior before and after .NET 8.0. Consider adding or updating unit tests to cover scenarios for TargetFrameworkVersion <8.0 and >=8.0 to ensure the EnableUnsafeBinaryFormatterSerialization property behaves as expected.
<!-- controls runtime behavior (AppContext & trimming) -->
elinor-fung
changed the title
MiYanni
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #33004
This was a workaround for #32969 which was fixed in 8.0 (at least the BinaryFormatter portion). The workaround was intended to be removed once that underlying issue was fixed.
Downloaded 8.0.0, checked the framework runtimeconfigs, and verified that running WinForms app without BinaryFormatter explicitly enabled in its runtime config works with 8.0.
cc @GrabYourPitchforks