Target DotNetDeltaApplier to net6.0#49543
Merged
tmat merged 1 commit intodotnet:mainfrom Jun 28, 2025
Merged
Conversation
Member
Author
|
@DustinCampbell ptal |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project target frameworks from netstandard2.1 to net6.0 to leverage newer APIs available in .NET 6.0 and later. Key changes include:
- Updating target frameworks and output paths in dotnet-watch.csproj and Microsoft.Extensions.DotNetDeltaApplier.csproj.
- Adjusting the framework mapping logic in HotReloadAppModel.cs.
- Changing Microsoft.DotNet.HotReload.Agent.Package.csproj to target net6.0.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BuiltInTools/dotnet-watch/dotnet-watch.csproj | Updated TargetFramework and TargetPath to reflect net6.0 usage |
| src/BuiltInTools/dotnet-watch/HotReload/AppModels/HotReloadAppModel.cs | Modified framework mapping to return net6.0 for .NET 6.0+ cases |
| src/BuiltInTools/HotReloadAgent/Microsoft.DotNet.HotReload.Agent.Package.csproj | Updated TargetFramework from netstandard2.1 to net6.0 |
| src/BuiltInTools/DotNetDeltaApplier/Microsoft.Extensions.DotNetDeltaApplier.csproj | Adjusted multi-target frameworks to net6.0;net10.0 and updated associated comments |
Comments suppressed due to low confidence (3)
src/BuiltInTools/dotnet-watch/dotnet-watch.csproj:70
- Confirm that the new TargetPath and framework settings are consistent with any tooling or scripts that reference this output location.
<SetTargetFramework>TargetFramework=net6.0</SetTargetFramework>
src/BuiltInTools/dotnet-watch/HotReload/AppModels/HotReloadAppModel.cs:29
- Ensure that mapping all .NET 6.0+ frameworks to 'net6.0' aligns with the intended behavior of the Hot Reload implementation.
"net6.0" or "net7.0" or "net8.0" or "net9.0" => "net6.0",
src/BuiltInTools/DotNetDeltaApplier/Microsoft.Extensions.DotNetDeltaApplier.csproj:12
- [nitpick] Verify that the updated multi-target framework setting and the revised comment sufficiently guide future changes, particularly regarding dependencies on dotnet-watch and HotReloadAppModel.TryGetStartupHookPath.
<TargetFrameworks>net6.0;net10.0</TargetFrameworks>
DustinCampbell
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targeting net6.0 allows us to use more APIs that are not available in netstandard2.1.
Source build actually has 6.0 ref pack, so we can target 6.0 instead of netstandard2.1.