Fixes for stable builds, and move away from using arch-specific properties#49017
Merged
mmitche merged 1 commit intodotnet:mainfrom May 16, 2025
Merged
Fixes for stable builds, and move away from using arch-specific properties#49017mmitche merged 1 commit intodotnet:mainfrom
mmitche merged 1 commit intodotnet:mainfrom
Conversation
Member
mmitche
commented
May 16, 2025
mmitche
commented
- Use correct stable/non-stable properties for various bits of layout infra to support stable builds
- Avoid using arch-specific properties so that vertical build can be simplified.
…rties - Use correct stable/non-stable properties for various bits of layout infra to support stable builds - Avoid using arch-specific properties so that vertical build can be simplified.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with stable builds by replacing arch-specific properties with standardized package properties to simplify the vertical build. Key changes include updating package references in various .targets and props files, revising dependency declarations in version files, and adjusting artifact naming to accommodate full NuGet version info.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Layout/redist/targets/RestoreLayout.targets | Replaced arch-specific and unstable package properties with stable alternatives. |
| src/Layout/redist/targets/Crossgen.targets | Updated shared framework version property for PGO-instrumented builds. |
| src/Layout/Directory.Build.targets | Modified SDK artifact naming to use the full NuGet version. |
| global.json | Updated runtime package property to use the stable platform version. |
| eng/Versions.props | Removed arch-specific properties in favor of standardized internal properties. |
| eng/Version.Details.xml | Revised dependency declarations to reflect the new property naming. |
| Directory.Build.props | Updated runtime and apphost aliases to reference the AppRef package versions. |
ViktorHofer
approved these changes
May 16, 2025
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
giritrivedi
pushed a commit
to IBM/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.