Skip to content

[browser/blazor] enable GenerateRuntimeConfigurationFiles#48916

Merged
pavelsavara merged 12 commits intodotnet:mainfrom
pavelsavara:enable_runtimeConfig
May 19, 2025
Merged

[browser/blazor] enable GenerateRuntimeConfigurationFiles#48916
pavelsavara merged 12 commits intodotnet:mainfrom
pavelsavara:enable_runtimeConfig

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented May 13, 2025 •
edited
Loading

Contributes to dotnet/runtime#97449
Together with dotnet/runtime#115113
Filled for the broken incrementalism dotnet/runtime#115646

@pavelsavara pavelsavara added this to the 10.0.1xx milestone May 13, 2025
@pavelsavara pavelsavara self-assigned this May 13, 2025
Copilot AI review requested due to automatic review settings May 13, 2025 16:27
@pavelsavara pavelsavara requested a review from a team as a code owner May 13, 2025 16:27
@pavelsavara pavelsavara requested a review from maraf May 13, 2025 16:27
@github-actions github-actions bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK label May 13, 2025
Copilot AI reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Blazor WebAssembly SDK targets to conditionally disable the generation of runtime configuration files for Blazor projects until .NET 10. The changes include updating the element to include a condition based on the target framework version.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 13, 2025

Thanks for your PR, @@pavelsavara.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@pavelsavara pavelsavara mentioned this pull request May 13, 2025
Merged
@pavelsavara
Copy link
Member Author

pavelsavara commented May 14, 2025

Log

[xUnit.net 00:00:42.71]     Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIncrementalismTest.Build_IsIncremental [FAIL]
[xUnit.net 00:00:42.71]       Expected boolean to be True, but found False.
[xUnit.net 00:00:42.72]       Stack Trace:
[xUnit.net 00:00:42.72]            at FluentAssertions.Execution.LateBoundTestFramework.Throw(String message)
[xUnit.net 00:00:42.72]            at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
[xUnit.net 00:00:42.72]            at FluentAssertions.Execution.AssertionScope.AddPreFormattedFailure(String formattedFailureMessage)
[xUnit.net 00:00:42.72]            at FluentAssertions.Execution.AssertionChain.FailWith(Func`1 getFailureReason)
[xUnit.net 00:00:42.73]            at FluentAssertions.Execution.AssertionChain.FailWith(Func`1 getFailureReason)
[xUnit.net 00:00:42.73]            at FluentAssertions.Execution.AssertionChain.FailWith(String message, Object[] args)
[xUnit.net 00:00:42.74]            at FluentAssertions.Primitives.BooleanAssertions`1.BeTrue(String because, Object[] becauseArgs)
[xUnit.net 00:00:42.74]         /_/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIncrementalismTest.cs(46,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIncrementalismTest.Build_IsIncremental()
[xUnit.net 00:00:42.74]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:42.74]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@pavelsavara pavelsavara mentioned this pull request May 16, 2025
Merged
@pavelsavara pavelsavara requested review from a team, arunchndr and tmat as code owners May 16, 2025 09:18
@pavelsavara
Copy link
Member Author

pavelsavara commented May 16, 2025

@maraf please look again, I made few more changes

maraf
maraf reviewed May 16, 2025
View reviewed changes
@pavelsavara pavelsavara merged commit 7f4eb8d into dotnet:main May 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maraf maraf maraf approved these changes

Copilot code review Copilot Copilot left review comments

@lewing lewing lewing approved these changes

@javiercn javiercn javiercn approved these changes

@tmat tmat Awaiting requested review from tmat tmat is a code owner

@arunchndr arunchndr Awaiting requested review from arunchndr

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK

Projects

None yet

Milestone

10.0.1xx

Development

Successfully merging this pull request may close these issues.

5 participants

@pavelsavara @lewing @javiercn @maraf