[release/9.0.1xx] Update GivenThatWeWantMSBuildToRespectCustomCulture.cs #47565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports a change to resolve failing tests caused by a recent VS update by removing the failing test related to custom culture behavior in MSBuild.
- Removed the failing test: SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail to align with the consolidated test theory.
Comments suppressed due to low confidence (1)
test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs:29
- The removal of the failing test 'SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail' might reduce coverage for scenarios where a build is expected to fail. Consider adding a comment explaining that this removal is intentional and that related scenarios are either no longer supported or are covered elsewhere.
[Theory]
Forgind
approved these changes
Mar 13, 2025
joeloff
approved these changes
Mar 13, 2025
3 tasks
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #47549