Allow disabling scenario-tests that don't work in the first build pass#47108
Allow disabling scenario-tests that don't work in the first build pass#47108akoeplinger wants to merge 2 commits intomainfrom
Conversation
ghost
added
E.g. publishing for browser-wasm from a windows-x64 vertical.
akoeplinger
force-pushed
the
akoeplinger-patch-1
branch
from
2ec2575 to
493e822
Compare
| <TestXmlOutputPath>$(ScenarioTestsResultsDir)$([System.DateTime]::Now.ToString("yyyy-MM-dd_HH_mm_ss")).xml</TestXmlOutputPath> | ||
| <ScenarioTestsAdditionalArgs>--xml $(TestXmlOutputPath) --target-rid $(TargetRid) --portable-rid $(PortableRid) --no-cleanup --no-traits Category=MultiTFM</ScenarioTestsAdditionalArgs> | ||
| <ScenarioTestsAdditionalArgs Condition="'$(DotNetBuildPass)' != '2'">$(ScenarioTestsAdditionalArgs) --no-traits Category=RequiresNonTargetRidPackages</ScenarioTestsAdditionalArgs> | ||
| <ScenarioTestsAdditionalArgs Condition="'$(DotNetBuildPass)' != '2' or '$(DotNetBuildSourceOnly)' == 'true'">$(ScenarioTestsAdditionalArgs) --no-traits Category=RequiresNonTargetRidPackages</ScenarioTestsAdditionalArgs> |
There was a problem hiding this comment.
Source-only builds use the MSFT upstream packages and should be able to run the test decorated with that trait, at least with the current state in main. CI tells me that the test is run and that it passes.
There was a problem hiding this comment.
It currently works because the workload manifests are downloaded from the Microsoft build and reference the versions built there, but that will change once the manifests are built as part of the sdk repo since they will then use the VMR version numbers.
There was a problem hiding this comment.
Source-build currently doesn't follow the VMR versioning: dotnet/source-build#4855
Does that make a difference?
FWIW I would prefer to not condition this on source-build until we make the change that requires this to change.
There was a problem hiding this comment.
FWIW I would prefer to not condition this on source-build until we make the change that requires this to change.
+1, keep in mind source-build previews unlike UB are shipping. That is to say SB is sensitive to temporary breakages.
There was a problem hiding this comment.
ok, I still expect this will break but we can deal with it at that point so I'll fold this change into my other PR.
E.g. publishing for browser-wasm from a windows-x64 vertical. Needed for dotnet/scenario-tests#216