Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Instead of having our own custom targets and tasks to publish a given VMR vertical, use the tooling in the Arcade SDK to publish a vertical.

Contributes to dotnet/arcade#15317

Depends on a bootstrap Arcade SDK containing dotnet/arcade#15572

… for a given vertical instead of having custom tasks
@ghost ghost added the untriaged Request triage from a team member label Feb 24, 2025
jkoritzinsky added a commit to jkoritzinsky/dotnet-sdk that referenced this pull request Mar 5, 2025
…ome root utility project. This build, however, only publishes the assets.

Unlike the approach I take in dotnet#47076, this approach allows our final "vertical" publish to use a the live Arcade logic instead of the bootstrapping Arcade.
@mmitche mmitche marked this pull request as ready for review March 28, 2025 16:10
@mmitche mmitche requested review from a team as code owners March 28, 2025 16:10
@jkoritzinsky jkoritzinsky changed the base branch from main to release/10.0.1xx-preview4 April 22, 2025 23:06
@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jkoritzinsky
Copy link
Member Author

Retargeted to release/10.0.1xx-preview4. Official build at https://dev.azure.com/dnceng/internal/_build/results?buildId=2693317&view=results.

Once the linked build is green, I can merge it in (and then it'll flow back to main in the standard SDK codeflow).

@mmitche
Copy link
Member

mmitche commented Apr 23, 2025

In the latest build, PackageArtifacts and PDBArtifacts are missing. I'll take a look in a few to see if I can figure out why.

@jkoritzinsky
Copy link
Member Author

I think I figured it out. The vertical manifests are expected to have the VerticalName attribute on them (that's how JoinVerticals knows the vertical an item is from).

New official build here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2693958&view=results

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented Apr 23, 2025

@jkoritzinsky
Copy link
Member Author

@jkoritzinsky
Copy link
Member Author

@mmitche
Copy link
Member

mmitche commented Apr 24, 2025

The latest issue appears to be that there are assets that are duplicated between verticals. These are PDBs. Two/three possible ideas:

  • These all should be published (no real overlap) and we could resolve this by staging the PDBs to unique directories.
  • These are cases where we should just select a single vertical
  • (last resort)...ignore asset selection issues in PDBs for now.

@mmitche
Copy link
Member

mmitche commented Apr 25, 2025

@mmitche
Copy link
Member

mmitche commented Apr 26, 2025

Looks like that didn't quite do it...it looks like the PhaseName didn't make it into the artifact names

@mmitche
Copy link
Member

mmitche commented Apr 28, 2025

Last issue appears that the PDBs are getting flattened in the final join, which we don't want.

@mmitche mmitche merged commit bf04e12 into dotnet:release/10.0.1xx-preview4 Apr 30, 2025
36 of 39 checks passed
@jkoritzinsky jkoritzinsky deleted the vertical-manifest-arcade branch May 5, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-VMR untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants