Enable signing in the VMR official pipeline#45517
Merged
ellahathaway merged 6 commits intodotnet:mainfrom Jan 7, 2025
Merged
Conversation
ghost
added
ellahathaway
force-pushed
the
enable-signing-vmr
branch
from
f181bc2 to
66c74fc
Compare
Member
Author
This was referenced Dec 20, 2024
mmitche
reviewed
Jan 6, 2025
mmitche
approved these changes
Jan 7, 2025
Member
Author
|
@mmitche - Can I get help merging this? SDK tests failed with errors unrelated to my changes. Thanks in advance. |
ViktorHofer
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4062
This enables signing the VMR official pipeline. Note that forced dry run signing is still being passed to Mac & Linux builds due to dotnet/source-build#4793.
Test build