sln-add: Only add guid on slnv12 files#45366
Merged
marcpopMSFT merged 3 commits intodotnet:mainfrom Dec 10, 2024
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
marcpopMSFT
approved these changes
Dec 10, 2024
Member
|
/backport to release/9.0.2xx |
Contributor
|
Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/12265342621 |
Contributor
|
@marcpopMSFT backporting to release/9.0.2xx failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: sln-add: Only add guid on slnv12 files
Using index info to reconstruct a base tree...
M src/Cli/dotnet/commands/dotnet-sln/add/Program.cs
A test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProj.slnx
A test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProjToEmptySln.slnx
A test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingNestedProj.slnx
A test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithInRootOption.slnx
A test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithSolutionFolderOption.slnx
A test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithAdditionalConfigs.slnx
A test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithMatchingConfigs.slnx
A test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithoutMatchingConfigs.slnx
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithoutMatchingConfigs.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithoutMatchingConfigs.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithMatchingConfigs.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithMatchingConfigs.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithAdditionalConfigs.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/TestAppWithSlnAndProjectConfigs/Results/ExpectedSlnFileAfterAddingProjectWithAdditionalConfigs.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithSolutionFolderOption.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithSolutionFolderOption.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithInRootOption.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingProjectWithInRootOption.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingNestedProj.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingNestedProj.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProjToEmptySln.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProjToEmptySln.slnx left in tree.
CONFLICT (modify/delete): test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProj.slnx deleted in HEAD and modified in sln-add: Only add guid on slnv12 files. Version sln-add: Only add guid on slnv12 files of test/TestAssets/TestProjects/SolutionFilesTemplates/ExpectedSlnFileAfterAddingLibProj.slnx left in tree.
Auto-merging src/Cli/dotnet/commands/dotnet-sln/add/Program.cs
CONFLICT (content): Merge conflict in src/Cli/dotnet/commands/dotnet-sln/add/Program.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 sln-add: Only add guid on slnv12 files
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
edvilme
pushed a commit
to edvilme/sdk
that referenced
this pull request
Dec 10, 2024
edvilme
pushed a commit
to edvilme/sdk
that referenced
this pull request
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #44570 to only add IDs to projects on .sln solution files, not on .slnx