Build the .NET SDK installer using the ASP.NET Core Runtime MSI instead of the wixlib #45346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of the wixlib The wixlib provides additional options that are not hooked up in the SDK installers, so we can use the MSI directly instead.
ghost
added
jkoritzinsky
added a commit
to jkoritzinsky/aspnetcore
that referenced
this pull request
Dec 6, 2024
Member
Author
|
Build failures are unrelated. This is ready for review |
Member
|
Taking a look |
joeloff
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wixlib provides additional options that are not hooked up in the SDK installers, so we can use the MSI directly instead (which dotnet/aspnetcore also publishes).