fix(cli): dotnet help new link opening#45282
Merged
baronfel merged 1 commit intodotnet:mainfrom Dec 10, 2024
Merged
Conversation
ghost
added
ajpinedam
commented
Dec 3, 2024
Contributor
Author
|
Running the dotnet CLI locally with the fix in this PR, shows the dotnet_cli_help_new_fix_smaller.mp4 |
ajpinedam
force-pushed
the
fix/ajpinedam/dotnet.help.new.link.opening
branch
from
7aacb36 to
fcb76d9
Compare
Forgind
approved these changes
Dec 4, 2024
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
I'm happy with this 🙂 Thanks for the contribution!
ajpinedam
force-pushed
the
fix/ajpinedam/dotnet.help.new.link.opening
branch
from
fcb76d9 to
ac48207
Compare
baronfel
approved these changes
Dec 5, 2024
This was referenced Dec 5, 2024
Member
|
/backport to release/9.0.2xx |
Contributor
|
Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/12264978382 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #45231
This PR fixes the issue where the
dotnet help newcommand does not open the online documentation.The solution was adding an interface
ICommandDocumentthat bothDocumentedCommandandNewCommandcould implement and then use this to validate the existence of a link.