sln-remove: Support for slnx#45160
Merged
edvilme merged 12 commits intodotnet:release/9.0.2xxfrom Jan 8, 2025
Merged
Conversation
ghost
added
edvilme
force-pushed
the
edvilme-slnx-remove
branch
3 times, most recently
from
364fdbf to
9c66d13
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
2 times, most recently
from
d57cd76 to
690dfb8
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
47218e8 to
7f9e329
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
7f9e329 to
d50d204
Compare
edvilme
commented
Dec 9, 2024
This was referenced Dec 10, 2024
kasperk81
reviewed
Dec 10, 2024
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
045d32e to
d4f1128
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
d4f1128 to
6120f36
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
6120f36 to
765016a
Compare
kasperk81
reviewed
Dec 13, 2024
Contributor
kasperk81
left a comment
kasperk81
left a comment
There was a problem hiding this comment.
hoist childrenByParent computation out of recursive step
Contributor
|
@edvilme lets address the feedback and get this in 9.0.200 to close the lid on this feature. without this, IDEs like vscode which rely on sdk aren't going to use this feature |
Member
|
@kasperk81 he's out for vacation - this command will still make 9.0.200 (code freeze is mid-January) but likely won't make a particular VS preview insertion as a result. |
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
951c6d3 to
765016a
Compare
edvilme
force-pushed
the
edvilme-slnx-remove
branch
from
5460cf7 to
224b9da
Compare
edvilme
removed request for
a team,
AntonLapounov,
akoeplinger,
lewing,
maraf,
pavelsavara,
tmat and
vijayrkn
MiYanni
approved these changes
Jan 7, 2025
Contributor
|
the non-recursive version is much simpler and easier to read edvilme#1, it builds and passes all tests in this pr. feel free to merge that pr, its commit will automatically show up here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #40913
This adds
dotnet sln removesupport for .slnx filesBreaking changes