Skip to content

randomize GetTestDestinationDirectoryPath#45130

Merged
edvilme merged 1 commit intodotnet:mainfrom
kasperk81:patch-4
Nov 26, 2024
Merged

randomize GetTestDestinationDirectoryPath#45130
edvilme merged 1 commit intodotnet:mainfrom
kasperk81:patch-4

Conversation

@kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Nov 26, 2024

lots of failures in theory tests such as

Microsoft.DotNet.Cli.Sln.List.Tests.GivenDotnetSlnList.WhenInvalidSolutionIsPassedItPrintsErrorAndUsage(solutionCommand: "sln") [FAIL]
      System.Exception : Test dir /private/tmp/helix/working/AD1509AD/w/BB910A35/e/testExecutionDirectory/WhenInvalidSo---F1406920_2 already exists

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Nov 26, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 26, 2024
Open
3 tasks
@kasperk81
Copy link
Contributor Author

kasperk81 commented Nov 26, 2024

@edvilme this will fix the directory name conflict seen in #44570 when there are more than two theories relying on distinct naming _1 and _2 are not enough

@kasperk81 kasperk81 mentioned this pull request Nov 26, 2024
Merged
@edvilme
Copy link
Contributor

edvilme commented Nov 26, 2024

@edvilme this will fix the directory name conflict seen in #44570 when there are more than two theories relying on distinct naming _1 and _2 are not enough

Thanks for your contribution! This will be very helpful both for that PR and for further testing scenarios :)

@edvilme edvilme merged commit 4317236 into dotnet:main Nov 26, 2024
@kasperk81 kasperk81 deleted the patch-4 branch November 26, 2024 20:24
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 12, 2024
@edvilme
randomize GetTestDestinationDirectoryPath (dotnet#45130)
38d1af1
@edvilme edvilme mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Forgind Forgind Forgind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kasperk81 @edvilme @Forgind