Skip to content

sln-list: Support for slnx#44537

Merged
edvilme merged 12 commits intodotnet:mainfrom
edvilme:edvilme-slnx-list
Nov 5, 2024
Merged

sln-list: Support for slnx#44537
edvilme merged 12 commits intodotnet:mainfrom
edvilme:edvilme-slnx-list

Conversation

@edvilme
Copy link
Contributor

@edvilme edvilme commented Oct 30, 2024 •
edited
Loading

Contributes to #40913

The dotnet CLI should support the new slnx format for building and in the existing solution management commands. It should also help interested users migrate to the new format.

This adds dotnet sln list support for .slnx files

image

This also adds reusable logic to SlnCommandParser to be reused by other sln commands moving forward.

@ghost ghost added Area-CLI untriaged Request triage from a team member labels Oct 30, 2024
@edvilme edvilme changed the title [IMP] sln-list: Support for slnx (WIP) sln-list: Support for slnx (WIP) Oct 30, 2024
@edvilme edvilme marked this pull request as ready for review October 30, 2024 19:25
@edvilme edvilme requested a review from a team October 30, 2024 19:26
@edvilme edvilme changed the title sln-list: Support for slnx (WIP) sln-list: Support for slnx Oct 30, 2024
@build-analysis build-analysis bot mentioned this pull request Oct 30, 2024
Open
kasperk81
kasperk81 reviewed Oct 31, 2024
View reviewed changes
kasperk81
kasperk81 reviewed Oct 31, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Oct 31, 2024
Closed
@edvilme edvilme mentioned this pull request Oct 31, 2024
Merged
kasperk81
kasperk81 reviewed Oct 31, 2024
View reviewed changes
@kasperk81
Copy link
Contributor

kasperk81 commented Nov 3, 2024

@baronfel this looks good?

baronfel
baronfel reviewed Nov 4, 2024
View reviewed changes
@edvilme edvilme requested a review from baronfel November 4, 2024 19:54
@build-analysis build-analysis bot mentioned this pull request Nov 5, 2024
Open
3 tasks
@edvilme edvilme merged commit bd5b082 into dotnet:main Nov 5, 2024
@mthalman
Copy link
Member

mthalman commented Nov 5, 2024

This broke in internal CI: https://dev.azure.com/dnceng/internal/_build/results?buildId=2575716&view=results (internal link). It looks like it got merged w/o syncing in the changes from #43015 that were merged before this one. They don't work together.

@edvilme edvilme mentioned this pull request Nov 5, 2024
Merged
@kasperk81
Copy link
Contributor

kasperk81 commented Nov 5, 2024

#44661

nagilson
nagilson reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@nagilson nagilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to review but this looks great! I may have tweaked the wording a little bit on the command strings, but that is a nit; I dont think its worth doing that now. Love the use of the Range Operator :)

@kasperk81 kasperk81 mentioned this pull request Dec 10, 2024
Open
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 10, 2024
@edvilme
sln-list: Support for slnx (dotnet#44537)
89f215f
@edvilme edvilme mentioned this pull request Dec 10, 2024
Merged
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 11, 2024
@edvilme
sln-list: Support for slnx (dotnet#44537)
8bbd19b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson left review comments

@baronfel baronfel baronfel approved these changes

+1 more reviewer

@kasperk81 kasperk81 kasperk81 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CLI untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@edvilme @kasperk81 @mthalman @baronfel @nagilson