Remove locale from diagnostic-ids link #42830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Member
Author
|
@marcpopMSFT kindly asking about the bug bar in sdk for such a change? |
Member
SDK is still fully open for checking in .NET 9. As we have tooling dependencies, we follow the VS bar which locks down in September. So feel free to check in. |
akoeplinger
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that we include a locale in the diagnostic-ids link emitted by APICompat. We should remove that as the doc page is also available in other locals.
Explicitly targeting release/9.0.1xx to still get this into .NET 9.