Skip to content

[release/9.0.1xx-preview5] Update dependencies from dotnet/runtime#41166

Merged
mmitche merged 4 commits intorelease/9.0.1xx-preview5from
darc-release/9.0.1xx-preview5-93e93d8e-4e2b-46cd-b8b4-d5691dbb521d
May 29, 2024
Merged

[release/9.0.1xx-preview5] Update dependencies from dotnet/runtime#41166
mmitche merged 4 commits intorelease/9.0.1xx-preview5from
darc-release/9.0.1xx-preview5-93e93d8e-4e2b-46cd-b8b4-d5691dbb521d

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 25, 2024 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.5.24264.2 to 9.0.0-preview.5.24273.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.5.24264.2 to 9.0.0-preview.5.24273.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/runtime

  • Subscription: c3e4f4a3-7996-46e6-976a-08dc7a5e2c49
  • Build: 20240528.5
  • Date Produced: May 28, 2024 9:01:41 PM UTC
  • Commit: d89832aaf3616212c6ffa32ed1320f5117907056
  • Branch: refs/heads/release/9.0-preview5

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
ba11386 
…0524.5

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24272.2 -> To Version 9.0.0-preview.5.24274.5

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24264.2 -> To Version 9.0.0-preview.5.24273.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels May 25, 2024
@v-wuzhai
Copy link
Contributor

v-wuzhai commented May 27, 2024

@jtschuster @dotnet/illink This error looks like the same as #41096. Could you take a look? Thanks!

@jtschuster
Copy link
Member

jtschuster commented May 28, 2024

The fix is in the latest builds, I'm not sure why it's not in the diff for this update. I think this just needs a newer build.

@nagilson
Copy link
Member

nagilson commented May 28, 2024 •
edited
Loading

Blazor WASM tests for publishing with VS are failing now. May you please take a look, would your changes influence this behavior?

Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests.WasmAoTPublishIntegrationTest.AoT_Publish_HostedAppWithScopedCss_VisualStudio

@jtschuster

@nagilson nagilson enabled auto-merge May 28, 2024 17:04
@jtschuster
Copy link
Member

jtschuster commented May 28, 2024

Yes, the Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests.WasmAoTPublishIntegrationTest.AoT_Publish_HostedAppWithScopedCss_VisualStudio failures I see were fixed by dotnet/runtime#102613, which is in 9.0.0-preview.5.24278.2 at the latest. This PR should update runtime dependencies to that version or later. I'm looking into how to trigger an update with Maestro, but I'm not very familiar with maestro and darc.

@nagilson
Copy link
Member

nagilson commented May 28, 2024 •
edited
Loading

darc get-subscriptions --source-repo https://github.com/dotnet/runtime --target-repo https://github.com/dotnet/sdk

Find the subscription with the id for this branch.

Then,
darc trigger-subscriptions --id id

I would do it myself to help as well but the credential provider is not working atm 🙃

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
f3b8d0a 
…0524.5

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24272.2 -> To Version 9.0.0-preview.5.24274.5

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24264.2 -> To Version 9.0.0-preview.5.24273.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@jtschuster
Copy link
Member

jtschuster commented May 28, 2024

Ah, the bug was just before the preview 5 snap and the fix was after. I'll backport it in runtime.

@jtschuster jtschuster mentioned this pull request May 28, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
2f1edf5 
…0528.5

Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.5.24272.2 -> To Version 9.0.0-preview.5.24278.5

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-preview.5.24264.2 -> To Version 9.0.0-preview.5.24273.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@mmitche
Copy link
Member

mmitche commented May 29, 2024

@jtschuster This bug needs approval and merge ASAP if it is to make p5.

@jtschuster
Copy link
Member

jtschuster commented May 29, 2024 •
edited
Loading

The linker changes in these commits aren't critical for the p5 sdk, if there's nothing else in these commits that need to get into the p5 sdk it's fine with me to leave these out.

@mmitche mmitche disabled auto-merge May 29, 2024 04:08
@mmitche mmitche merged commit 09a2e23 into release/9.0.1xx-preview5 May 29, 2024
@mmitche mmitche deleted the darc-release/9.0.1xx-preview5-93e93d8e-4e2b-46cd-b8b4-d5691dbb521d branch May 29, 2024 04:09
@jtschuster jtschuster mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurepa dkurepa dkurepa approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v-wuzhai @jtschuster @nagilson @mmitche @dkurepa