Merged
Conversation
ghost
added
This comment was marked as outdated.
This comment was marked as outdated.
anatawa12
changed the title
anatawa12
force-pushed
the
crossplatform-resource-updater
branch
from
257b785 to
8d0ee4f
Compare
ResourceUpdater.IsSupportedOS() will always return true since dotnet/runtime#89303
anatawa12
force-pushed
the
crossplatform-resource-updater
branch
from
8d0ee4f to
5d5e759
Compare
Contributor
Author
|
@dotnet/domestic-cat ready for review |
elinor-fung
approved these changes
Aug 24, 2023
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
This looks good to me from the runtime side of consuming HostWriter. @dotnet/domestic-cat could someone take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add e2e test for dotnet/runtime#89303.
Remove ResourceUpdater.IsSupported guard