Exclude Publish="false" package assets from build output, don't infer Publish="false" from PrivateAssets="all"#3311
Closed
dsplaisted wants to merge 1 commit intodotnet:masterfrom
Closed
Conversation
… Publish="false" from PrivateAssets="all"
peterhuene
reviewed
Jun 7, 2019
| var platformLibrary = _runtimeTarget.GetLibrary(_task.PlatformLibraryName); | ||
| if (platformLibrary != null) | ||
| // Exclude the platform library | ||
| if (_task.PlatformLibraryName != null) |
Contributor
There was a problem hiding this comment.
Is this check redundant?
peterhuene
approved these changes
Jun 7, 2019
Contributor
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Just the minor comment above. So happy about this change!
Member
Author
|
We're not going to be able to this in this way for now. There are EntityFramework "design" packages which are supposed to be used with PrivateAssets="all", where the assets are supposed to go in the build output folder but not the publish output. |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…build 20191024.8 (dotnet#3311) - Microsoft.NET.Sdk.Razor - 5.0.0-alpha1.19524.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/designs#78