Add reference to empty Microsoft.NETCore.App package#3195
Merged
dsplaisted merged 2 commits intodotnet:masterfrom May 2, 2019
Merged
Add reference to empty Microsoft.NETCore.App package#3195dsplaisted merged 2 commits intodotnet:masterfrom
dsplaisted merged 2 commits intodotnet:masterfrom
Conversation
This comes via the PackagesToReference metadata on KnownFrameworkReference
ericstj
approved these changes
May 2, 2019
Contributor
|
I think the name "PackagesToReference" is a bit confusing since these are only referenced when there are other packages. Can we come up with a better name. PackageToReferenceWhenThereAreOtherPackages is probably too long, but is there a nicer way to say that? We can handle that as a follow up since the name is already baked into bundled versions. |
nguerrera
approved these changes
May 2, 2019
|
|
||
| if (frameworkReference != null) | ||
| { | ||
| if (!string.IsNullOrEmpty(knownFrameworkReference.PackagesToReference)) |
Contributor
There was a problem hiding this comment.
nit: reduce nesting by using &&
| { | ||
| foreach (var packageAndVersion in knownFrameworkReference.PackagesToReference.Split(';')) | ||
| { | ||
| var items = packageAndVersion.Split('/'); |
Contributor
There was a problem hiding this comment.
nit:: So many allocations, but we already have an issue to speed up this task.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…0191016.03 (dotnet#3195) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.1
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jun 7, 2022
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jun 21, 2022
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference to the Microsoft.NETCore.App package is specified via the PackagesToReference metadata on KnownFrameworkReference. This metadata was added in dotnet/installer#1766, and the package was produced in dotnet/core-setup#5893.
Once https://github.com/dotnet/core-setup/issues/6222 is done, this should fix #3044. This PR also adds a test case for that issue, which is currently skipped.
This PR removes the implicit reference to the Microsoft.NETCore.Platforms package, as that will now come in as a dependency of the Microsoft.NETCore.App package.