Add a JsonSerializerIsReflectionEnabledByDefault property#31626
Add a JsonSerializerIsReflectionEnabledByDefault property#31626eerhardt merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
…ext.Json one. Remove the defaulting of the System.Text.Json feature switch until a decision can be made when to turn it off by default.
|
I'm marking this PR as "ready for review". I've removed the defaulting of the feature switch until a decision can be made in dotnet/runtime#84378. I've removed the temporary ASP.NET JSON feature switch and am using the new one from System.Text.Json. This is needed to unblock ASP.NET work needed in preview4. So I want to get this merged without blocking on how to default the feature switch for all apps. |
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
If this doesn't change the default value yet, this shouldn't impact the various MAUI workloads.
|
I'm going to merge this by EOD today to unblock ASP.NET. Please let me know if you have any feedback. |
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Can't approve my own PR, but final changes LGTM.
…s move off of it.
|
I needed to add back the ASP.NET feature switch until we can move the ASP.NET libraries off of it. Need to do this in a staged manner so we don't regress. |
8 participants
Adds a msbuild property that ties to the feature switch implemented in dotnet/runtime#83844.
Also disables the property whenPublishAot=true.Remove ASP.NET's feature switch and use JsonSerializerIsReflectionEnabledByDefault instead.