Update GenerateLayout.targets for Microsoft.CodeAnalysis.NetAnalyzers packaging structure changes #29906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React to package structure updates in dotnet/roslyn-analyzers#6325 and dotnet/roslyn-analyzers#6427 to generate props/targets/config files in `buildtransitive` folder
ghost
added
the
Contributor
Author
Member
|
I think this should be synchronized with NetAnalyzers version update that has the change |
Contributor
Author
Yes, will have to wait for dotnet/roslyn-analyzers#6427 to be merged and then get the new NetAnalyzers version update which has this fix. |
mavasani
commented
Jan 13, 2023
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@nagilson for review. The build is passing fine for all but Ubuntu. I am not sure if this is a CI issue, because the file that is being complained as missing is indeed present in the package. |
Contributor
Author
|
Closing in favor of #29911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React to package structure updates in dotnet/roslyn-analyzers#6325 and dotnet/roslyn-analyzers#6427 to copy props/targets/config files from the
buildtransitivefolder in the NuGet package