Add DynamicCodeSupport Feature Switch #29785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support in the SDK for the new RuntimeFeature.IsDynamicCodeSupported feature switch added in dotnet/runtime#39806. When PublishAot is set in a project, DynamicCodeSupport gets defaulted to false.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
dsplaisted
approved these changes
Jan 6, 2023
vitek-karas
approved these changes
Jan 6, 2023
Fix test to build correctly.
sbomer
approved these changes
Jan 6, 2023
AntonLapounov
approved these changes
Jan 8, 2023
MichalStrehovsky
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support in the SDK for the new RuntimeFeature.IsDynamicCodeSupported feature switch added in dotnet/runtime#39806. When PublishAot is set in a project, DynamicCodeSupport gets defaulted to false.