Fix br compression size regression in Blazor WASM #27659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reacting to dotnet/runtime#72266, which changed CompressionLevel.Optimal to no longer mean "smallest size", but instead a balance between compression speed and output size. In Blazor WASM publishing, we really want smallest size - it is preferred to spend more time during publish in order for less bytes to be downloaded and cached in the browser. The fix is to change the default compression level to SmallestSize in the brotli tool used by WASM publish.
eerhardt
requested review from
DrewScoggins,
SamMonoRT,
lewing and
stephentoub
eerhardt
requested review from
TanayParikh,
captainsafia,
javiercn and
mkArtakMSFT
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lewing
approved these changes
Sep 2, 2022
stephentoub
approved these changes
Sep 2, 2022
SamMonoRT
approved these changes
Sep 2, 2022
eerhardt
added
Area-AspNetCore
DrewScoggins
approved these changes
Sep 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reacting to dotnet/runtime#72266, which changed CompressionLevel.Optimal to no longer mean "smallest size", but instead a balance between compression speed and output size. In Blazor WASM publishing, we really want smallest size - it is preferred to spend more time during publish in order for less bytes to be downloaded and cached in the browser.
The fix is to change the default compression level to SmallestSize in the brotli tool used by WASM publish.
Here are my numbers I captured locally from doing
dotnet publish -c Releasewith adotnet new blazorwasmapp.This fixes this regression seen on our size perf chart: