Replace rollForward in tools runtimeconfig#24817
Closed
Conversation
Tools like dotnet-format specify a rollForward of 'LatestMajor' which forces runtime change. Replace this rollForward with 'Major' which merely allows for a runtime change.
ghost
added
the
nohwnd
reviewed
Apr 13, 2022
Member
nohwnd
left a comment
nohwnd
left a comment
There was a problem hiding this comment.
LGTM, were you able to test it locally?
Member
|
Since we now default to Major, is this PR needed anymore? #31957 |
Member
|
Do you have plans to test the tool on multiple .NET versions? |
Member
|
Old PR review: This PR is more than a year old and does not appear to have active engagement. A reviewer has been notified offline to review and take action. If no action is taken, this PR will be closed in 14 days. Please comment if you want this PR left open for further investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools like dotnet-format specify a rollForward of 'LatestMajor' which forces runtime change. Replace this rollForward with 'Major' which merely allows for a runtime change.