-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add design for cross-version workloads #24070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| ```xml | ||
| <ImportGroup Condition="'$(RunAOTCompilation)' == 'true' And '$(TargetFrameworkIdentifier)' == '.NETCoreApp' And '$(TargetFrameworkVersion)' == '6.0'"> | ||
| <Import Project="Sdk.props" Sdk="Emscripten.Sdk.net6" /> | ||
| </ImportGroup> | ||
| <ImportGroup Condition="'$(RunAOTCompilation)' == 'true' And '$(TargetFrameworkIdentifier)' == '.NETCoreApp' And '$(TargetFrameworkVersion)' == '7.0'"> | ||
| <Import Project="Sdk.props" Sdk="Emscripten.Sdk.net7" /> | ||
| </ImportGroup> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When .NET 7 is stable, do we anticipate that building a net6.0-android project would use the .NET 7 Android workload (SDK & .targets)? Or will it somehow need to use the old .NET 6 targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should use the .NET 7 MSBuild tasks and targets from the workload, and they should be written so that they support targeting .NET 6 and .NET 7.
(A workload could decide to use the .NET 6 targets, but I wouldn't recommend that because it could be hard to keep multiple SDK versions and multiple workload targets all compatible with each other).
| </ImportGroup> | ||
| ``` | ||
|
|
||
| ## .NET 6 manifests in .NET 7 SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How far back does this go? Will .NET 8 support net7.0-android and net6.0-android? Or is it only have 1 LTS release behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's up to the workload. For .NET, we still support building projects all the way back to .NET Core 1.0. I understand that for iOS and Android this is not as important, as you need to move forward to new tooling / targeting new versions of .NET in order to continue to publish to the app stores. So supporting one previous version for iOS and Android is probably fine.
This describes how we can consume "runtime-specific" workload assets in later versions of the .NET SDK.