Skip to content

GenerateDepsFile no longer respects FilesToSkip from runtime packs #3010

@sbomer

Description

@sbomer
  • Runtime pack dependencies in deps.json and in the DependencyContext model have a "runtimepack." prefix prependend to the nuget package id (see 16eddf3#diff-0723634e548f98293eebe3970b71e0ddR328).
  • The heuristic in GetPackageParts gets the package id from the name of a nuspec in a parent directory:
    var nuspecs = dir.GetFiles("*.nuspec");
    if (nuspecs.Length > 0)
    {
    packageId = Path.GetFileNameWithoutExtension(nuspecs[0].Name);

GenerateDepsFile uses GetPackageParts to build the list of packages with dependencies to remove. When it looks for files to trim from the dependency model, it doesn't match any of the dependencies that have the "runtimepack." prefix, so those files don't get skipped.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions