Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All packages targeting netcoreapp3.0 have a 'Microsoft.NETCore.Platforms' dependency in nuspec #2976

Closed
natemcmaster opened this issue Feb 22, 2019 · 1 comment
Closed

All packages targeting netcoreapp3.0 have a 'Microsoft.NETCore.Platforms' dependency in nuspec #2976

natemcmaster opened this issue Feb 22, 2019 · 1 comment
Assignees
@dsplaisted
Milestone
3.0.1xx

Comments

@natemcmaster
Copy link
Contributor

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props

Lines 81 to 87 in 0690b28

<!-- Reference the Platforms package in order to supply the RID graph to NuGet.
This can be removed once we do https://github.com/dotnet/cli/issues/10528 or
https://github.com/NuGet/Home/issues/7351 -->
<PackageReference Include="Microsoft.NETCore.Platforms"
Version="$(BundledNETCorePlatformsPackageVersion)"
IsImplicitlyDefined="true"
Condition="('$(_TargetFrameworkVersionWithoutV)' != '') And ('$(_TargetFrameworkVersionWithoutV)' >= '3.0')"/>

This should probably have been 'PrivateAssets=All'.

All aspnet 3.0 Preview 3 packages which target netcoreapp3.0 have this dependency in their nuspec. cc @Eilon @livarcocc

image
@peterhuene peterhuene added this to the 3.0.1xx milestone Feb 22, 2019
natemcmaster pushed a commit to dotnet/extensions that referenced this issue Feb 22, 2019
Update core-setup version and workaround dotnet/sdk#2976
466163b
natemcmaster pushed a commit to dotnet/efcore that referenced this issue Feb 22, 2019
Update dependencies and workaround dotnet/sdk#2976
cfd20f1
@natemcmaster natemcmaster mentioned this issue Feb 22, 2019
Merged
natemcmaster pushed a commit to dotnet/razor that referenced this issue Feb 22, 2019
Update dependencies and workaround dotnet/sdk#2976
8ec3f80
@natemcmaster natemcmaster mentioned this issue Feb 22, 2019
Merged
natemcmaster pushed a commit to dotnet/aspnetcore that referenced this issue Feb 22, 2019
Update dependencies and workaround dotnet/sdk#2976
6b13b30
natemcmaster added a commit to dotnet/extensions that referenced this issue Feb 22, 2019
@natemcmaster
Update core-setup version and workaround dotnet/sdk#2976 (#1154)
ce197a8
natemcmaster added a commit to dotnet/razor that referenced this issue Feb 22, 2019
@natemcmaster
Update dependencies and remove some unused version variable overrides (…
6708297 
…#238)

* Update dependencies
* Add workaround for dotnet/sdk#2976
* Remove unused NETStandard package version variable and overrides
* Update xunit to 2.4.1
natemcmaster added a commit to dotnet/efcore that referenced this issue Feb 22, 2019
@natemcmaster
Update dependencies and workaround dotnet/sdk#2976 (#14775)
d50d70b
@livarcocc
Copy link
Contributor

@dsplaisted to take a look.

natemcmaster added a commit to dotnet/aspnetcore that referenced this issue Feb 23, 2019
@natemcmaster
Update dependencies and react to changes (#7844)
1b27c99 
* Add workaround for dotnet/sdk#2976
* Add new restore sources
* Update BAR manifest to point to  https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json
* Obsolete WithCulture
* Add retries to dockerbuild.sh
* Ensure each test run gets a unique in-memory database
@natemcmaster natemcmaster mentioned this issue Feb 23, 2019
Merged
clairernovotny pushed a commit to dotnet/reactive that referenced this issue Feb 23, 2019
Workaround dotnet/sdk#2976
8775aa2
clairernovotny pushed a commit to dotnet/reactive that referenced this issue Feb 24, 2019
Workaround dotnet/sdk#2976
cf99807
dsplaisted added a commit to dsplaisted/sdk that referenced this issue Feb 24, 2019
@dsplaisted
Mark implicit platforms package reference as PrivateAssets
8c5a7a0 
Fixes dotnet#2976
@dsplaisted dsplaisted mentioned this issue Feb 24, 2019
Merged
@ghost ghost closed this as completed in 83566d1 Feb 25, 2019
wli3 pushed a commit that referenced this issue Feb 7, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/cli build 20190926…
b0055f8 
….10 (#2976)

- Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19476.10
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this issue May 7, 2020
@natemcmaster
Update dependencies and remove some unused version variable overrides (…
635c0d0 
…#238)

* Update dependencies
* Add workaround for dotnet/sdk#2976
* Remove unused NETStandard package version variable and overrides
* Update xunit to 2.4.1
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsplaisted dsplaisted

Labels
None yet
Projects
None yet
Milestone
3.0.1xx
Development

No branches or pull requests
4 participants
@dsplaisted @livarcocc @peterhuene @natemcmaster