Skip to content

PackageOverrides.txt is not parsed correctly #10904

New issue
New issue
Open
Open
PackageOverrides.txt is not parsed correctly#10904
Milestone
Backlog
@ericstj

Description

@ericstj
ericstj
opened on Mar 18, 2020

See:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/ResolveTargetingPackAssets.cs

Lines 146 to 151 in e2faeba

private TaskItem CreatePackageOverride(string runtimeFrameworkName, string packageOverridesPath)
{
TaskItem packageOverride = new TaskItem(runtimeFrameworkName);
packageOverride.SetMetadata("OverriddenPackages", File.ReadAllText(packageOverridesPath));
return packageOverride;
}

This reads the entire contents of the file and sets it as metadata.

This creates a problem, because the consumption of the PackageOverrides assumes delimited packages, and the task is not inserting delimiters.

See #2937 (comment)

To fix this the task should either insert the delimiters, or we should change the file to append a semi-colon after every package ID.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions