Merged
Conversation
Replace the build infrastructure with csproj based project.
rpetrusha
approved these changes
Jun 15, 2018
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
LGTM, @BillWagner. You can merge when you're ready.
Contributor
|
🎆 I've been meaning to get to this! 🎆 |
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
Replace the build infrastructure with csproj based project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the build infrastructure with csproj based project.
This is the last project.json based build that exists.
Fixes dotnet/docs#1445
Once this is merged, I'll close the project