Add System.Private.DeveloperExperience.Console #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this System.Private library depends on Console (and exists solely because CoreLib cannot reference System.Console), placing this in the libs partition. I'm not actually porting all of System.Private.DeveloperExperience.Console - the dependency on System.Private.StackTraceGenerator was annoying so I removed it. I'm deleting System.Private.StackTraceGenerator - this only works on Windows systems that have DIA registered machine wide - that's not the case (by default) since VS 2015.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Aug 27, 2020
...em.Private.DeveloperExperience.Console/src/System.Private.DeveloperExperience.Console.csproj
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 27, 2020
...em.Private.DeveloperExperience.Console/src/System.Private.DeveloperExperience.Console.csproj
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 27, 2020
MichalStrehovsky
commented
Sep 1, 2020
src/coreclr/src/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Show resolved
Hide resolved
jkotas
reviewed
Sep 1, 2020
...src/nativeaot/System.Private.CoreLib/src/Internal/DeveloperExperience/DeveloperExperience.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 1, 2020
| } | ||
| } | ||
|
|
||
| public virtual string CreateStackTraceString(IntPtr ip, bool includeFileInfo) |
Member
There was a problem hiding this comment.
This does not need to be public with virtual methods anymore.
Member
Author
There was a problem hiding this comment.
It does if we want to bring back dotnet/corert#7658 at some point.
jkotas
reviewed
Sep 1, 2020
...src/nativeaot/System.Private.CoreLib/src/Internal/DeveloperExperience/DeveloperExperience.cs
Outdated
Show resolved
Hide resolved
scalablecory
pushed a commit
that referenced
this pull request
Sep 22, 2020
This change rotates the encryption key used for protecting Stateless Retry tokens every 30 seconds. The rotation is performed in a lazy manner, to avoid needing a timer, and only actually occurs when a Stateless Retry token is being sent from the server. In order to prevent the encryption key from being freed while in use, all callers are required to hold a global lock while using the key. This could impact performance and can be improved by either ref-counting the keys, or by having encryption keys duplicated per CPU. The existing tests already cover Stateless Retry tokens being sent. A test case is needed for the negative case where the client responds with the token after the key for that token has been rotated.
MichalStrehovsky
pushed a commit
to MichalStrehovsky/runtimelab
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this System.Private library depends on Console (and exists solely because CoreLib cannot reference System.Console), placing this in the libs partition.
I'm not actually porting all of System.Private.DeveloperExperience.Console - the dependency on System.Private.StackTraceGenerator was annoying so I removed it. I'm deleting System.Private.StackTraceGenerator - this only works on Windows systems that have DIA registered machine wide - that's not the case (by default) since VS 2017.
Depends on #70.