Skip to content

Make libraries build with Native AOT corelib #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 11 commits into from
Aug 28, 2020
Merged

Make libraries build with Native AOT corelib #70

MichalStrehovsky merged 11 commits into from
Aug 28, 2020

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Aug 26, 2020

No description provided.

@MichalStrehovsky MichalStrehovsky added the area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation label Aug 26, 2020
jkotas
jkotas approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/coreclr/src/nativeaot/System.Private.CoreLib/src/System/Environment.CoreRT.Win32.cs Outdated
{
public static partial class Environment
{
#pragma warning disable CS8763 // A method marked [DoesNotReturn] should not return.
Copy link
Member

@jkotas jkotas Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed when ExitProcess is marked DoesNotReturn? Sounds like a bug.

Copy link
Member Author

@MichalStrehovsky MichalStrehovsky Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does sound like a bug, but I couldn't quickly make an isolated repro in VS with shipping Roslyn and my level of caring for nullable analysis is next to zero so I didn't spend more time on it.

Copy link
Member

@jkotas jkotas Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it is weird that it works everywhere else. Wasn't it just an oversight?

Copy link
Member Author

@MichalStrehovsky MichalStrehovsky Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to submit it without this suppression, but I'm pretty sure I was getting build failure without this suppression and the DllImport is annotated.

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Aug 27, 2020 •
edited
Loading 

'F:\workspace\_work\1\s\artifacts\obj\coreclr\nativeaot\System.Private.CoreLib\..\..\Windows_NT.x64.Debug\src\nativeaot\Runtime\Full\AsmOffsets.cs' could not be found. [F:\workspace\_work\1\s\src\coreclr\src\nativeaot\System.Private.CoreLib\System.Private.CoreLib.csproj]

Of course it cannot, because the runtime was built into "Windows_NT.x64.Checked", but libs apparently don't know what "checked" is.

@jkotas What do you think - should we kill off the Checked builds in the CI in lieu of Debug? Debug is plenty fast and I never enjoyed debugging optimized code anyway (I don't remember if I ever built CoreCLR as checked either).

Edit: Seems like I got it working.

@MichalStrehovsky MichalStrehovsky mentioned this pull request Aug 27, 2020
Merged
@MichalStrehovsky MichalStrehovsky merged commit 3c109fb into dotnet:NativeAOT Aug 28, 2020
@MichalStrehovsky MichalStrehovsky deleted the apicompat branch August 28, 2020 10:09
@MichalStrehovsky MichalStrehovsky mentioned this pull request Sep 19, 2020
Closed
6 tasks
scalablecory pushed a commit that referenced this pull request Sep 22, 2020
@nibanks
Add Support to Convert Logs to PowerShell Scripts (#70)
5c21ce3 
Now the PowerShell scripts can optionally convert the collected logs to text automatically.
MichalStrehovsky pushed a commit to MichalStrehovsky/runtimelab that referenced this pull request Oct 15, 2021
@vitek-karas
Fix where test temp files are written (dotnet#70)
4456188 
They should be in artifacts/testcases (and not in artifacts/bin/testcases).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky @jkotas