Anchorsupdate #588
Anchorsupdate #588
Conversation
|
|
|
As agreed, I added a public RegexOtions.DFA enum that triggers SRM from within the regex Run method. |
… full anchor support (work in progress)
|
Did a major rewrite of the core SRM matcher engine, now with full anchor support. |
…dfull of test that dont pass seem suspicious/wrong)
| namespace System.Text.RegularExpressions.SRM | ||
| { | ||
| [Serializable] | ||
| internal struct RegexOptions |
There was a problem hiding this comment.
Now that you're merging the code, seems the SRM versions of IgnoreCase, etc can be replaced by simply using the existing enum? And maybe retaining some of your helper methods here but no more need for any "mapping" from one to the other.
|
|
||
| /// <summary> | ||
| /// This method is here for perf reasons: if InitializeSRM is NOT called in the | ||
| /// Init method, we don't load SRM.Regex when instantiating a regex that does not use the DFA option |
There was a problem hiding this comment.
Now it's all in the same assembly, does no-inlining matter? The type will be loaded anyway, and Jitting will only happen if it ends up needing the code.
There was a problem hiding this comment.
Removed the comment and the complier method attribute. Added another note there as a reminder that in fact RightToLeft can be supported now -- fairly easily I think.
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
I didn't review the SRM parts, but looks good to me
|
This is great! Thanks! |
|
I fixed the merge conflict in the project files. |
|
@veanes thanks, as you saw I did a big merge to bring everything up to date. That probably introduced the file header check as well. |
3 participants
First major integration of SRM into .NET Regex.
Includes support for anchors and initial unit tests.