Add more stackoverflow avoidance to Regex #1662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Contributes to #1537 |
Member
Author
|
I will close this and re-make it against dotnet/runtime once things are merged there. |
|
@stephentoub since this PR me and Margus looked through all the algorithms and found a few more cases that needed addressing. I'll address those, so I can include both these and the new ones in a new PR. |
Member
Author
|
Sounds good. Thanks, @olsaarik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olli, please let me know if there's a reason some of these aren't necessary. I just went through this one file looking for obvious self-recursion.