Report diagnostics in generator #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
approved these changes
Oct 9, 2020
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
A few comments. Overall it looks good.
AaronRobinsonMSFT
added
the
area-DllImportGenerator
…eneration is not supported
Split basic compile tests into with/without diagnostics. As we add support for different types / configuration, the appropriate snippets can be moved from expecting diagnostics to not expecting diagnostics. Enable emitting generated files in demo project.
Update README to point out emitting generated source to disk
Make Compiles test check that all reported diagnostics are DLLIMPORTGEN Add doc listing diagnostics reported by the P/Invoke source generator
elinor-fung
force-pushed
the
generatorDiagnostics
branch
from
016f71d to
2d5dc68
Compare
50 tasks
jkoritzinsky
pushed a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
Commit migrated from dotnet/runtimelab@98f55be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DLLIMPORTGEN001: TypeNotSupportedDLLIMPORTGEN002: ConfigurationNotSupportedMarshalAs)GeneratorDiagnosticsfor use by all stub generation to report diagnostics if necessaryDiagnosticstests use of theDiagnosticResultfrom the analyzer testing infrastructure for convenienceCompilestests now have diagnostics. I have split them into two groups (NoDiagnosticsandWithDiagnostics) for now - as we add support for types and different marshalling configurations, they should eventually all becomeNoDiagnosticsThis doesn't deal with all the
TODOs we have for reporting diagnostics, but there is now a place to put / report them all.cc @AaronRobinsonMSFT @jkoritzinsky