-
Notifications
You must be signed in to change notification settings - Fork 214
Merge from dotnet/runtime #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add server core testing to Windows x64 * Add server core testing * Use 20h1 queue instead * Remove runtime testing until we get more capacity on 20H1 queue * Use 2004 image * Skip tests on Server core * PR Feedback and fix build * Disable more server core tests * Disable more tests on Server Core * Attempt fixing failing process test in server core address feedback * Fix PlatformDetection.IsInContainer for windows and feedback from Eirik's change * PR Feedback * Don't run server core on PRs yet until we get more capacity Co-authored-by: Eirik Tsarpalis <[email protected]>
…lues (#42728) * [wasm][crypto] RandomNumberGenerator mapped to Web Crypto getRandomValues - Uses Web Crypto API [`getRandomValues`](https://www.w3.org/TR/WebCryptoAPI/#Crypto-method-getRandomValues) if available. - Falls back to `/dev/urandom` as default if the crypto library is missing. * Remove the emscripten interface code from the driver.c. * remove extraneous code comment * Move emscripten definition around. * Address review comment * Add javascript bridge implementation library to Native source tree. - Javascript checks for crypto interface and uses `crypto.getRandomValues` - Add api bridge call when building for emscripten browser. - separate out into browser subdirectory - If we couldn't find a proper implementation, as Math.random() is not suitable we will abort. ``` ABORT: no cryptographic support found getRandomValues. Consider polyfilling it if you want to use something insecure like Math.random(), e.g. put this in a --pre-js: var crypto = { getRandomValues: function(array) { for (var i = 0; i < array.length; i++) array[i] = (Math.random()*256)|0 } }; ``` * Change tests to set random values of the buffer instead of return a single value. * Remove old test code * Remove testing code * Incorporate the PAL bridge layer into the `--js-library` build process * Address review comments about directory structure and naming * Update src/mono/wasm/runtime-test.js Co-authored-by: Ryan Lucia <[email protected]> * Add note about insecure code for testing purposes * Formatting * Return -1 if crypto does not exist instead of aborting from js. This allows the managed code exception flow to continue as normal. Co-authored-by: Ryan Lucia <[email protected]>
Add two directories to NATIVE_DLL_SEARCH_DIRECTORIES to single-file bundles: 1. The bundle exe directory 2. If the bundle extracts any files, the extraction directory Fixes #42772
- used by two test projects
… wrong endian (#42848) When the Disassembler prints 4-byte and 8-byte values it should print them in little endian format
* Introduce THIRD-PARTY-NOTICES file for deployment with shared host package * Update of THIRD-PARTY-NOTICES for .NET 5.0 release * Update src/installer/pkg/THIRD-PARTY-NOTICES.TXT Co-authored-by: Adeel Mujahid <[email protected]> * Update libunwind name in root TPN file to prevent regression in future updates * Update libunwind license * Updates based on review comments Co-authored-by: Adeel Mujahid <[email protected]>
Add cross compilation testing for crossgen2. The goal here is to cover cross compilation for the framework libraries, with support for testing cross compilation behavior between across the large swath of possible cross target possibilities. This testing is added to the crossgen2 outerloop and is based on the work that @echesakovMSFT built for crossgen1 for cross target support for Linux X64 to Linux Arm. (The testing model has been tweaked to allow for general purpose cross target testing.) Important details. There is now a cross targeting build job, which builds (on either X64 Windows or X64 Linux) the framework dlls for a given target architecture, and captures their SHA1 hashes. Then there is a comparison job which will run crossgen2 on an arbitrary set of platforms targetting a specific OS/Architecture pair. The current state is that is known that the x86 compiler does not quite produce identical output when varied between 64 and 32 bit, there are significant issues compiling arm32 code, and arm64 code is nearly perfect with cross compilation.
* Optimize -X and MathF.Abs(X) for floats Co-authored-by: Tanner Gooding <[email protected]>
* Throw PNSE on sync version of BrowserHttpHandler.Send * Mark HttpClientHandler.Send as unsupported on browser * Update reference source
… locales (#42982)
… C (#41872) library that can be shared between Mono as well as CoreCLR runtime. Port follows same guidelines setup for event pipe port #34600. Diagnostic server library is currently hosted as part of event pipe library but hosting its own runtime shim as well as source files (so could be split into separate library if ever make sense). Diagnostic Server have dependencies on event pipe library (and reuse part of event pipe runtime shim from its how shim). This is the first PR getting the code from diagnostic server codebase over to C library.
With dotnet/xharness#315 we can now make the test output similar to the regular xunit desktop runner. It no longer prints the passed tests by default, only failing tests. To get the old behavior, add the `-v` flag back to xharness in tests.mobile.targets or check the new wasm-console.log file in the xharness-output folder. ``` XHarness command issued: wasm test --app=. --engine=V8 --engine-arg=--stack-trace-limit=1000 --js-file=runtime.js --output-directory=/Users/alexander/dev/runtime/artifacts/bin/System.Runtime.Handles.Tests/net5.0-Release/browser-wasm/AppBundle/xharness-output -- --run WasmTestRunner.dll System.Runtime.Handles.Tests.dll -notrait category=OuterLoop -notrait category=failing info: 21:57:45.3244690 v8 --expose_wasm --stack-trace-limit=1000 runtime.js -- --run WasmTestRunner.dll System.Runtime.Handles.Tests.dll -notrait category=OuterLoop -notrait category=failing info: Arguments: --run,WasmTestRunner.dll,System.Runtime.Handles.Tests.dll,-notrait,category=OuterLoop,-notrait,category=failing info: console.debug: MONO_WASM: Initializing mono runtime info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28 info: Initializing..... info: Discovering: System.Runtime.Handles.Tests.dll (method display = ClassAndMethod, method display options = None) info: Discovered: System.Runtime.Handles.Tests.dll (found 14 of 15 test cases) info: Starting: System.Runtime.Handles.Tests.dll fail: [FAIL] SafeWaitHandleTests.SafeWaitHandle_False info: Assert.False() Failure info: Expected: False info: Actual: True info: at SafeWaitHandleTests.SafeWaitHandle_False() info: at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) info: Finished: System.Runtime.Handles.Tests.dll info: info: === TEST EXECUTION SUMMARY === info: Total: 14, Errors: 0, Failed: 1, Skipped: 0, Time: 0.097211s info: info: 21:57:46.3323620 Process exited with 1 ```
* Reenable MUSL ARM tests The packages for MUSL ARM should now be available, so reenable the libraries tests in the CI * Update DotnetHost and DotnetHostPolicy versions * Add Linux arm musl to libraries queues * Reenabling the arm32 queue in the coreclr templates queues * Updated versions by darc tool, reverted libraries/helix-queues-setup.yml
Co-authored-by: vargaz <[email protected]>
* accross -> across * additionaly -> additionally * adddress -> address * addrees -> address * addresss -> address * aligment -> alignment * Alignement -> Alignment * alredy -> already * argment -> argument * Argumemnts -> Arguments
For newer Windows SDKs, the stdalign.h header is present, but the alignas macr is not defined unless the compiler adds the std:c11 or newer. Until we can set the std:c11 flag, work around the missing alignas macro using cmake config.
We're installing [email protected] from Homebrew so we should check that version. It looks like CI Macs don't set the /usr/local/opt/openssl symlink anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.